Update gtm_datalayer.html #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix syntax. Validated via JSON lint.
Update version
tdlowden
approved these changes
Jul 8, 2024
tdlowden
approved these changes
Jul 8, 2024
btylerburton
approved these changes
Jul 8, 2024
btylerburton
reviewed
Jul 8, 2024
| @@ -11,14 +11,14 @@ | |||
|
|
|||
| <script type="application/ld+json" class="jsonld-dataset"> | |||
| dataLayer = [{ | |||
There was a problem hiding this comment.
do we need to push this object TO anything?
is datalayer created already or do we need to instantiate the var?
There was a problem hiding this comment.
@btylerburton This would be the next thing I try if the syntax fixes dont work. Made comment here: GSA/data.gov#4783 (comment)
There was a problem hiding this comment.
if window.dataLayer exists already this would replace it with this. Typically, you'd push so as not to wipe/replace anything pre-existing.
There was a problem hiding this comment.
That's a good point. I don't think that the dataLayer exists prior, but I'm not sure how to test that. Definitely very open to advice/contributions for the front end stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix syntax. Validated via JSON lint.